search

GregLyons / poke-team

TypeScript-React app for designing competitive Pokemon teams.
https://billspc.dev
4 stars 0 forks source link

Bug: False flags when importing RBY teams #4

Closed PlagueVonKarma closed 2 years ago

PlagueVonKarma commented 2 years ago

Presumably, this occurs for GSC as well.

When importing a Gen 1 team, you will have "No Ability" get flagged despite requesting the format Pokepaste/Showdown uses. I believe that there should be an exception made when plugging these in. Abilities do not exist in RBY or GSC. image

Once removed, it will check for natures, despite RBY/GSC not having natures at all. image

GregLyons commented 2 years ago

I added a few lines that'll ignore the ability, held item, and nature checks if they don't exist in the given gen (before gen 3, before gen 2, before gen 3, respectively). Here's a screenshot of the import working with both "Ability: No Ability", and with no Ability at all. This change should be live now.

import-gen1

Thanks for finding this!