search

GregTech6 / gregtech6

This is the Official Repository of the Mod GregTech 6 for Minecraft 1.7.10
https://gregtech.mechaenetia.com
Other
188 stars 53 forks source link

some HBM compat from playtesting #49

Closed laurynasl closed 3 years ago

laurynasl commented 3 years ago

-meteorite fragment: iron scrap from showeling crucible autoconverted into this (exploit), scrabidium hammer became uncraftable because max stacksize changed from 64 to 18 +phosphorus dust: to make saturnite craftable +iron plate: to make fluid identifiers craftable (machine template folder)

GregoriusT commented 3 years ago

wait meteorite scrap should be meteoric iron

stacksize i did not think of, need to check that one

what was the iron plate issue? i need to be careful with unification order of iron stuff

HbmMods commented 3 years ago

Fluid identifiers from nuclear tech can only be made with NTM's iron plates instead of "plateIron", but that's something I should fix instead of making GT have NTM's iron plates as the unification target.

laurynasl commented 3 years ago

I disabled meteorite fragments after I put some iron things into crucible (maybe tracks), then shoveled out meteorite fragments, which had max stacksize of 18. Looked like an exploit.

GregoriusT commented 3 years ago

There is a lot of Recipes where i noticed you didnt use oredict, i think asbestos ingots were one of those cases, if i remember right.

I also noticed that "Gol198" was misspelled in the oredict, unsure if that was a joke or a typo.

Most unification targets are because of your radiation effects on the dusts and ingots, or because of dumb technicalities like Uranium and Uranium238 not being the same (which is an issue on my end for sure, as it's a holdover from ic2)

There is a bunch of things i definitely need to fix (that i didn't find yet), since gt6 does change a LOT of things without even ME knowing. (too much automatic XD)

But hey, my Dynamite works with the depth ores, and my worldgen doesn't kill the depth stuff either, so that's nice.

Btw i'm not sure if your config for ores works, because i still got your ores in my perpetually resetting world. also mid air shale in my superflat.

There is just so much stuff to add compat for XD

HbmMods commented 3 years ago

Many recipes weren't made with oredict in mind because I never expected any other mod to use half those ingots, a good amount only exist so that the shredder recipes are registered dynamically. For now I've changed all the asbestos sheets I could find into "ingotAsbestos", but there's still quite a few dusts that aren't oredicted at all.

"Gol198" was definitely a typo, I'll fix that right away.

Unifying items into their NTM counterparts for their item traits will hopefully stop being necessary in the near future since I'm planning on replacing the current item trait system (again) because it's really limited. The new system would ideally be mostly oredict-driven, have more graceful ways of sliding around radiation values for depleted fuels (at least better than the hacksaw solution it uses right now) and have IMC functionality so other mods can use it as well.

The ore configs should work, and even if they didn't there's new configs to fully turn off regular veins called 2.D00_overworldOres, B:2.D01_netherOres and 2.D02_endOres which should keep ore gen turned off even if some config keys were changed or added. Floating schist layers was a confirmed issue until a few weeks ago but I haven't tested the new generator on thin superflat worlds yet (world gen is scary).

GregoriusT commented 3 years ago

yeah the schist generated a month ago or so, i hope it wont block off caves anymore. XD

and oredict is indeed a better solution overall, but as long as there is no conflicts with other mods forced unification, i dont have to remove it on my end. I can also give it lower priority whenever i feel the need for that.

btw flaxbeards plates and your billets both have a value of 6 nuggets, so i randomly decided to add a ton of oredicted billets myself (items with metadata are great for that), which just "happen" to have recipes to turn them into flaxbeards plates if available. the oredictname of whose would be "billetCopper" for example. I found a few surprising uses for them too, like throwing those into a crucible instead of ingots or nuggets, which for automation CAN be more convenient. ^^

GregoriusT commented 3 years ago

Just to get this correct:

laurynasl commented 3 years ago

"Meteoric Iron Scrap" has 2 issues: stacksize and easy way to get it from showeling iron scrap from crucible. I got "Meteoric Iron Scrap" instead of iron scrap for some reason...

GregoriusT commented 3 years ago

Uh are you sure you can replicate that Issue? Because this shoveling* Issue sounds rather impossible to happen. I need you to make sure this wasn't a random accident. ;)

GregoriusT commented 3 years ago

@laurynasl yeah i cannot replicate your meteorite fragment issue whatsoever, no matter how much iron and meteoric iron i throw into a crucible and shovel back out.

Anyways I feel like I need to start distinguishing Red Phosphorus from White Phosphorus. My own Phosphorus is Yellow, and then there is Forestry's Blue-ish Phosphorus...