GregTech6 / gregtech6

This is the Official Repository of the Mod GregTech 6 for Minecraft 1.7.10
https://gregtech.mechaenetia.com
Other
189 stars 53 forks source link

Reactor overhaul part 3 #7

Closed Erik3003 closed 4 years ago

Erik3003 commented 4 years ago

ONLY MERGE when the new durability system of part 2 has been tested, as this PR implements the new system for IC2 Coolant, because that is needed for neutron moderators.

Added Neutron Moderators, allowing for a lot of fuels to be used in supercritical reactors. Added a lot of new coolants. Added new byproducts from depleted fuel rods. Fixed a bug where Geiger counter would not work on 1x1 reactors. Made reactors automateable. Fixed the formatting errors.

GregoriusT commented 4 years ago

You still did not turn off the Autoformatting in its entirety, if Files are changed more than they need to be then that is a sure sign that there is something changing the formatting.

Erik3003 commented 4 years ago

It's only the empty lines that get changed, not really anything I can do about it.

GregoriusT commented 4 years ago

I am 100% sure it did not do that in previous commits before, so what did you change on your Setup to make that happen?

OvermindDL1 commented 4 years ago

It looks like it's just pruning end-of-line whitespace, this is extremely common as end-of-line whitespace breaks not only expected cursor positions but also some posix'y tools, so it's enforced disabled in almost every text editor out, and IDE's are just fancy text editors so it looks right?

OvermindDL1 commented 4 years ago

However if it bugs you to look at then set the PR view to ignore whitespace change by adding &w=1 to the url query or selecting Hide Whitespace Changes in the tools (gear) menu, you'll get this: https://github.com/GregTech6/gregtech6/pull/7/files?diff=split&w=1

Oh, also I use split diff view, for the usual 'unified' view that would instead be: https://github.com/GregTech6/gregtech6/pull/7/files?diff=unified&w=1

GregoriusT commented 4 years ago

Wouldn't it be better for the PR itself to not contain whitespace changes on githubs end, instead of only hiding them from Greg? Also I explained to you plenty of times how broken stuff is when such whitespaces aren't there because Eclipse.

OvermindDL1 commented 4 years ago

Eclipse issues are not related to file issues. ^.^

OvermindDL1 commented 4 years ago

This is looking quite nice. ^.^