[Suggestion] Add config option to make GT water flow like vanilla water

[kappa-maintainer]

I am using GregGen to generate my world, but the cave connectivity it brought allow GT water to fill every cave under swamp and ocean. Mining under dirty water with debuff is not fun at all, maybe add a config option to tweak water's mechanism is a good idea.

[GregoriusT]

Wait wasn't there an option to limit spread of the different types of Water?

B:OceanBlocksSpreadToAir=false

This would be one example, and I dont think Rivers and Swamps spread infinitely. I really need to get my Dev Environment up and running on my new Computer...

[kappa-maintainer]

I have toggled that option, but it did not prevent creating new source blocks in the air. I also checked the source, this option can only apply to ocean water. The main problem is, GT water can spread horizontally in the air to form new source blocks without the need of hitting blocks, so one source block can easily fill a whole giant cave system. Update: Rivers and Swamps don't create source blocks, but can still produce flowing fluid blocks and fill caves.

[kappa-maintainer]

Some video and screenshots: https://webmshare.com/jx45g

[kappa-maintainer]

You may want to look at my commit to fix this: https://github.com/kappa-maintainer/gregtech6/commit/8b3a3bad0644c78a74edd7a3f9baed75c8e9acef Basically, it reintroduced the vanilla horizontal flowing check, and reduced seawater's source making ability.

[GregoriusT]

Are you sure you know what you are doing there? Pretty sure only one of those checks would need changing to fix the whole sideways flowing thing, not literally all of them. At that point you could just disable Worldgen of Riverwater itself (yes config exists for that too) and get the same experience, since Drains and Stuff still do Biome based checks for backwards compatibility with older Rivers.

But yeah I will add a Config for that one, once I am back at developing Stuff instead of playing Factorio...

[kappa-maintainer]

Well, I already have a survival world and I don't want to regenerate it or deal with WorldEdit yet, so I decide to do some coding. These new fluids have their usages, that's why I tend to preserve them. At last, those extra checks are used to stop seawater from creating more source blocks in many circumstances. I didn't touch the swamp water part, just too lazy to check another class.

[kappa-maintainer]

When I jump on grass path blocks from Et Futurum, there is a small chance of glitching player movement. It seems caused by GT grass blocks' incorrect bounding box, so I made another commit: https://github.com/kappa-maintainer/gregtech6/commit/67b5ac122f5d80cdb1d99e97a40229b00caf96d3

[GregoriusT]

The GT6 Grass Path Blocks have the correct intended bounding Box. Also how exactly do you get the Et Futurum Grass Path Blocks in the first place? GT6 Shovels dont make those.

[kappa-maintainer]

I installed Village Names to get some new village building, but it can only use grass path from Et Futurum. When I jumped on those blocks, things happened...

[kappa-maintainer]

GT6's current grass path is 16 16 16 in game, not the correct 16 15 16

[GregoriusT]

That is because there is worse issues if I make it Soulsand height, resulting in Slabs and Stairs and such not being usable adjacent to paths at all. This again is very much intended to be using a full Block Collision Box.

[kappa-maintainer]

So that's why EF's path block has a full block option... Never mind, I found the discussion issue, toggling EF's full block option on seems better...

[GregoriusT]

Okay I will convert Grass Paths in a 3x3 Radius around the Players stepping on them instead of just doing a 1x1. This should fix "most" of the glitching through Floor Issue.

[GregoriusT]

by the way, the change you needed for the Water thing was adding 'mFlowsOnWater && ' to this:

int tFlowMeta = (mFlowsOnWater && aWorld.getBlock(aX, aY-densityDir, aZ) instanceof BlockWaterlike ? 1 : quantaPerBlock - quantaRemaining + 1);

And ofcourse adding that variable itself and its Config assignment. ;)

[GregoriusT]

Okay that did somehow not work... I mustve made a mistake somewhere, but i will fix it within uhh a few hours i guess

[kappa-maintainer]

Now the river blocks seem working as intend, they do still flood caves but will no longer flood every cave in 10*10 chunks. As for the ocean block, some ignored logic somehow enabled them to create source blocks outside the ocean biome, which needs further fix.

[GregoriusT]

Are you sure it is not just the "2 sources create a third" mechanic working for oceans?

[kappa-maintainer]

That's what I got when testing the new behavior, I have no idea how these source blocks were created in non-ocean biome

[GregoriusT]

Thanks for the Minimap, that explains it easily. Beach Biome counts as Ocean too and this is super close to the Biome, so this can still happen through various interactions with closeby Water Blocks, since all "different" Water Blocks get converted into full Ocean Sources.

Btw having Caves full of Water near the Ocean is actually a nice thing, super easy Mob Proofing!

[kappa-maintainer]

Actually, it was in plain biome, but whatever, because I got Mariculture installed now. This mod fits perfectly in underwater mining. My only concern remains now is whether the wetsuit can protect me from swamp water...

[GregoriusT]

Not quite, there is a beach less than two chunks away, so chain reactions CAN spread ocean water this far quite easily. You should never just see "is this specific Block in the Biome?" as a criteria, because it is completely enough for the Biome to be closeby due to chain reactions with the vanilla alike "2 sources ALWAYS make a third" Mechanic Ocean Water has ONTOP of the normal spreading, together with Ocean Water converting regular Water, which results in EVEN MORE source Blocks. Yes it can go far if certain things happen, and that is normal.

[kappa-maintainer]

Ocean block counts the bottom block when creating new sources, I guess that's why it can spread like the screenshot... About the wetsuit, its texture can't fully cover player, so it does not in the HAZMATS list, which make sense. But the list itself have some problem: 1. It seems missing IC2's hazmat suit 2. Space suits should be able to protect players from chem gas and liquid too

[GregoriusT]

What Wet Suit? I never saw a Mod add that.

And IC2 Hazmat would be a bit OP if it did everything.

[kappa-maintainer]

Mariculture's wetsuit. I wanted to find a mod to both allow me to swim faster and avoid swamp water poison, but it turned out I can only choose one.

[kappa-maintainer]

The step logic got fixed in recent release of Et Futurum Requiem. Would you lower the height of grass path to 15/16 block?

[GregoriusT]

Here is the problem with that, my Path exists without Et Futurum too, and it has some different Features aswell (like turning into Slabs automatically). What purpose would having it 15/16ths tall even have? (remember, I am not completely bound to "whatever Mojang did", I can improve things)

Also if I remember correctly (correct me if I'm wrong), there still is the issue of not being able to go into a 2 block tall doorway when being on a slightly less tall Path Block (I remember that from Soulsand in ye olden days).

[kappa-maintainer]

The latest release of Et Futurum has fixed the step into 2 blocks tall space problem by mixin (tested), so I think adding a config of grass path height to fit actual model would be a good idea now