search

GregTech6 / gregtech6

This is the Official Repository of the Mod GregTech 6 for Minecraft 1.7.10
https://gregtech.mechaenetia.com
Other
188 stars 53 forks source link

Minor shading issue with rocks #85

Open embeddedt opened 2 years ago

embeddedt commented 2 years ago

A rock placed against a wall causes the wall to be improperly shaded, as though there is a solid block there. Here are two screenshots, flipping between them should make the issue apparent.

2022-06-04_13 55 33 2022-06-04_13 55 36

The reason this occurs is probably because the underlying block does not have the canBlockGrass flag set to true (the name is bad, it actually relates to transparency for lighting). Vanilla Minecraft has a similar issue with fences and setting this flag to true fixes that.

Unfortunately, I am not sure if there is a way of fixing this without splitting rocks and other non-full blocks into their own block ID, as there isn't enough context at rendering time to know the position of the block in the world.

GregoriusT commented 2 years ago

Alternatively, wouldn't enabling Smooth Lighting fix it too?

embeddedt commented 2 years ago

I have smooth lighting enabled already.

GregoriusT commented 2 years ago

Hrrm, I am not sure I can properly fix it, but I will leave this Issue open as a reminder to at least look at it later. ^^