[Suggestion]Let the machines have their sounds.

GregTechCE / GregTech

GregTech rewrite for modern versions of Minecraft

GNU Lesser General Public License v3.0

271 stars 150 forks source link

[Suggestion]Let the machines have their sounds. #1106

Open shoulder0902 opened 4 years ago

shoulder0902 commented 4 years ago

Until now I have played the gt5u, and the major reason of which is GTCE not have few sounds. I'm not the expert, but I mean if you can get some ones from open-source? I believe a lot players are puzzled, too. Hope you can deal with it, please!

Agrax commented 4 years ago

I'm not AN expert

Other than that: find us open-source machine sounds and we can add them in like 2 minutes. The issue is not w/ difficulty of such a task, but w/ the accessibility of open-source sounds for machines. As for GT5u - it had a permission to use IC2 sounds, but we don't

LAGIdiot commented 4 years ago

First thing first adding sounds to machines should not be that big deal but we would need to have some.

As far as I am aware there is no one who can mix sounds in development team. And right now we don't own any sounds (also we don't have permission to use these from IC2 like GT5U does). Adding sounds from opensource should be okay but it would required to re-vision licensing (and even adding acknowledgement would be pain). But main problem is that we are not aware of any opensource machine sounds pack that would suit our needs. And having sounds just for few machines would look silly.

Needles to say if you can produce for us (or at least recommend) sound pack we will give it a look.

K-Anator commented 3 years ago

I had commented on #820 , which covers the same issue. So I have two questions:

Does anyone have a list of sounds that are required? I have a massive library (90GB, so not massive, but still, pretty big) that I hold a personal/commercial license for. And would be keen on trying to produce sounds for GTCE.
Does GTCE still reference the old IC2 sounds? IE, could I drop in a resource pack with the IC2 sounds to get sounds back in the interim?

Edit:

To clarify, the audio I would be using to create the sounds would be coming from [https://sonniss.com/gameaudiogdc]. As stated, the samples are "... royalty-free and commercially usable. No attribution is required and you can use them on an unlimited number of projects."

LAGIdiot commented 3 years ago

@K-Anator sorry I totally miss your comment (as I am mostly working through Discord).

I give quick glance to provided link and it seems it should be alright for our needs. But we would need to take more serious look if we decide to use any of them as licensing problems are not fun. Though I am quite interested.

Regarding your questions: 1) There is no list of sounds that we need. But if I am correct except sound for steam exhaust we don't have any. 2) Currently there are no placeholders or hooks in code that would load sounds and play them. As there was no reason to have them. All this would have to be written form scratch.

K-Anator commented 3 years ago

@LAGIdiot No problem dude, I unfortunately haven't found the time to mess around yet either so no worries. I do hope this library can bring sounds to GTCE though, cause that license is so, so sweet, and the collection is absolutely massive. I'm looking at it now, and it appears I'm missing the 2020 archive, but the 2015-2019 ones consists of 94.9 GB of audio spread across 3288 files. There's gotta be some stuff in there that can be used, even if it needs some tweaks.

l1stochekkk commented 1 year ago

hi! I hope you know how to add sounds to Gregtech CE, because I am sound designer and I want to create my own sounds for my favourite tech mod for Minecraft. So I can share my sounds with you. If you can connect sounds in gtce - connect with me. my email: rubalkinmakx@gmail.com

Exaxxion commented 1 year ago

@l1stochekkk GTCE is no longer being actively developed. A fork of this mod called GTCEu is where all development interest moved to. That mod is still in beta, but among many other changes it has had machine sounds for a long time.

l1stochekkk commented 1 year ago

@Exaxxion I play very big and cool modpack with GTCE, so replacing GTCE with GTCEu will break all modpack. I've asked modpack developer with this problem of machine sounds, but he doesn't know how to fix it. That's why I've asked somebody here how can know how to add sounds into GTCE :(

Exaxxion commented 1 year ago

Your options would basically be implementing it yourself in a fork and either

getting it approved on CurseForge as a new mod, or
creating patches for the latest release using something like Bansoukou.

Because there is no active development going on, I would not hold out on anything happening in an official capacity here.