[BUG] Pipes unable to reconnect without breaking and replacing

GregTechCE / GregTech

GregTech rewrite for modern versions of Minecraft

GNU Lesser General Public License v3.0

268 stars 150 forks source link

[BUG] Pipes unable to reconnect without breaking and replacing #1438

Open serenibyss opened 3 years ago

serenibyss commented 3 years ago

Describe the bug Pipes are unable to be reconnected when wrenching them in certain ways.

Versions Forge: 14.23.5.2847 GTCE: 1.11.1.632 Modpack: None Addons: None

Setup Playing Solo, Dev environment New world generated Yes

Steps To Reproduce 1) Place down a straight line of pipes (any type) 2) Wrench the right connection point between any two pipes 3) You are now unable to reconnect the pipe by wrenching the side of the left pipe

Expected behavior Pipes should reconnect when wrenched.

Additional context If you wrench the side of the right pipe (before trying to wrench the side of the left pipe), it will reconnect. If you first wrench the side of the right pipe, then the side of the left pipe, and then the side of the right pipe again, it also reconnects. It seems that when a pipe connection is wrenched, it does not tell both sides to not connect, and similarly does not tell both sides to reconnect when wrenched again.

Archengius commented 3 years ago

"blocked" status is individual for each pipe, clicking on the neighbor pipe will not make blocked pipe unblocked. It is working as intended.

serenibyss commented 3 years ago

After discussion on Discord, I suggested that pipes should retain this "blocking" mode per side, but should be changed slightly to follow the rules:

When a side is blocked, it will not allow new connections when a new pipe is placed adjacent to that side
When a side is blocked, and a pipe is currently adjacent, wrenching either adjacent side of the currently blocked connection will connect the pipes

A further suggestion to this idea:

Wrenching a connection away between two pipes should enable "blocking" state on the connected sides for both pipes, instead of just one of them

LAGIdiot commented 3 years ago

@DStrand1 Can you please explain to me "When a side is blocked, it will not allow new connections when a new pipe is placed adjacent to that side" I did not get what you mean by that one.

serenibyss commented 3 years ago

The idea is: you can set a side as blocked on a pipe, so that when you place a new one, they do not immediately connect. This is current behavior, I just want to mention that it would not change with my suggestions.

The suggestions here and the comment before this one are basically how EnderIO conduits are handled, so I feel doing it for GT pipes would make them more intuitive, since nearly everyone uses conduits.

LAGIdiot commented 3 years ago

Thanks for explanation. Now I understand.

I like this proposal and I would like to see it implemented. But I would like to add one more thing and that is some indicator for "blocked" that is displayed on placed pipe when holding pipe or wrench so it is obvious when connection will not be made.