GregTechCE / GregTech

GregTech rewrite for modern versions of Minecraft
GNU Lesser General Public License v3.0
267 stars 150 forks source link

[Suggestion] Move away from enums #1661

Open idcppl opened 3 years ago

idcppl commented 3 years ago

Is your feature request related to a problem? Please describe. A lot of the material system is attached to enums that dev's are forced to use EnumHelper for. In example,

Describe the solution you'd like To move these over to registration maps.

warjort commented 3 years ago

If you are going to do this, then you need to make sure that things that depend on the ordinal still work as before.

e.g. the order that OrePrefix handlers are run

https://github.com/GregTechCE/GregTech/blob/dde025306a81abf2d7ad10561fcd3553805ca17e/src/main/java/gregtech/api/unification/ore/OrePrefix.java#L415