search

GregTechCEu / GregTech-Modern

GregTech CE Unofficial for modern versions
GNU Lesser General Public License v3.0
239 stars 132 forks source link

Flint knife/sword and butchery knives can have their enchantments extracted #1301

Open JuiceyBeans opened 1 month ago

JuiceyBeans commented 1 month ago

Checked for existing issues

Tested latest version

GregTech CEu Version

1.2.2.a

Recipe Viewer Installed

JEI

Environment

Singleplayer

Cross-Mod Interaction

Yes

Other Installed Mods

Apotheosis

Expected Behavior

Enchantments should not be able to be extracted

Actual Behavior

Mods that let you extract enchantments from tools let you remove Fire Aspect and Looting from knives and butchery knives. This is stupidly broken for obvious reasons, especially with Apotheosis installed, which lets you combine them up to Looting VII

Steps to Reproduce

(Apotheosis route) use a tome of scrapping on a butchery knife. Repeat and combine as much as you want

Additional Information

Might be worth looking into how Quark gives golden tools innate fortune? Apotheosis cannot extract enchantments from them this way https://github.com/VazkiiMods/Quark/blob/63ba30f7cea35906aedc2d96a3d289c0569b0e1b/src/main/java/org/violetmoon/quark/content/tweaks/module/GoldToolsHaveFortuneModule.java#L35

shadow7483147 commented 1 month ago

Confirming with Experience Obelisk's Precision Dispeller as well.