search

GregTechCEu / GregTech-Modern

GregTech CE Unofficial for modern versions
GNU Lesser General Public License v3.0
268 stars 162 forks source link

Fix ore vein changes being overwritten. #1436

Closed Fuyukai closed 3 months ago

Fuyukai commented 3 months ago

See #1435.

screret commented 3 months ago

Did you test that this change doesn't actually leave any ore veins dangling around?

screret commented 3 months ago

Also you need to run spotless

Fuyukai commented 3 months ago

I tested it with the integrated server this morning and then the dedicated server (fixes the bug, and doesn't leave ore veins hanging) but re-tested it with the dedicated server first when I woke up and found a classloading bug that I didn't notice the first time, fixed in the subsequent commit. (There's no possible code path where old veins are left hanging anyway.)

Ore veins are still semi-broken in the REI display, but that happens on the trunk anyway and I believe is down to an REI misbehaviour of it just not reloading plugins after a reconnect.

AncientShotgun commented 3 weeks ago

Sorry to necro this, but should I make a note of this issue in the packdev section of the docs for the versions affected by it?