GregTechCEu / GregTech-Modern

GregTech CE Unofficial for modern versions
GNU Lesser General Public License v3.0
291 stars 172 forks source link

Add config toggle for fortune on ores #1887

Open JuiceyBeans opened 2 months ago

JuiceyBeans commented 2 months ago

What

Mfw the mod adds fortune to tools but its useless Adds a config option for fortune working on ore drops (off by default)

Implementation Details

Added a new config option and an if statement to block loot drop MixinHelper to apply fortune if oreFortuneDrops is true

Outcome

Turning on oreFortuneDrops makes fortune work on ores

JuiceyBeans commented 2 months ago

WHOOPS DID NOT MEAN FOR THAT TO REFERENCE AN ISSUE LMAO

Ghostipedia commented 2 months ago

Against this being merged. Fortune should ideally have a chance to drop crushed ores, not full raw. And an equally slimmer chance for bonus 'dust' rolls.

Context ; This was a system discussed as a balance solution vs direct raw ores. which become absurdly difficult to balance around in the presence of over-enchanting. Even packs like GTNH of all things limit Fortune to a Max of 3 and don't allow >3 to work

JuiceyBeans commented 2 months ago

Meant this as a placeholder for players (and packdevs) who want to use it until the Fortune rework happens eventually:tm:

Better to have something instead of nothing but wasted tools until it happens

Ghostipedia commented 2 months ago

It makes more sense to directly implement properly than add a temp solution. As temporary solutions can easily become permanent ones. We can talk over a proper implementation in the discord but until then I'm going to mark this for do not merge

JuiceyBeans commented 1 month ago

OOPS