Issues associated with merged PRs aren't closed - Githubissues

GregTechCEu / GregTech-Modern

GregTech CE Unofficial for modern versions

GNU Lesser General Public License v3.0

295 stars 175 forks source link

Issues associated with merged PRs aren't closed #2415

Closed a-a-GiTHuB-a-a closed 4 days ago

a-a-GiTHuB-a-a commented 4 days ago

Checked for existing issues

[X] I have checked for existing issues, and have found none.

Tested latest version

[X] I have checked that this occurs on the latest version.

GregTech CEu Version

null

Minecraft Version

null

Recipe Viewer Installed

None

Environment

GitHub

Cross-Mod Interaction

Unsure

Other Installed Mods

none

Expected Behavior

When a PR addressing an issue is merged, the associated issue is closed.

Actual Behavior

The issues remain open and clog up the actual unaddressed issues.

Steps to Reproduce

go to this page
find an issue like #2238 or #2399
see that they have a merged PR associated, but they're still open???
no indication if there are still bugs that weren't addressed in the first PR

Additional Information

issue authors ghosted us :<

Pumpkin7266 commented 4 days ago

that's because the pr descriptions aren't triggering the github auto issue closer

a-a-GiTHuB-a-a commented 4 days ago

oh. so what will?

screret commented 4 days ago

the PR's creator just used the wrong keyword, that's all. we have to close them manually when that happens.