Issue with GT blocks and Timber Frames/Braces from Supplementaries

GregTechCEu / GregTech-Modern

GregTech CE Unofficial for modern versions

GNU Lesser General Public License v3.0

267 stars 157 forks source link

Issue with GT blocks and Timber Frames/Braces from Supplementaries #51

Closed ChromaPIE closed 10 months ago

ChromaPIE commented 1 year ago

GregTech CEu Version

v1.0.2

Recipe Viewer Installed

REI

Environment

Not related

Cross-Mod Interaction

Yes

Expected Behavior

Timber Frames/Braces from Supplementaries shows GT blocks inserted with correct textures and colors.

Like: (Redstone Block)

Actual Behavior

Before:

After: (Tested with several GT ores and material storage blocks)

Steps to Reproduce

See the screenshots above.

Additional Information

No response

screret commented 1 year ago

I believe this is caused by how ldlib's block renderer doesn't return any materials that the "subrenderer" might be using, but instead an always empty collection.

screret commented 1 year ago

E.g. this mixin should also exist for getMaterials

screret commented 10 months ago

should be fixed with #529.