GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
227 stars 174 forks source link

Miners collecting cobblestone while it shouldn't #1202

Closed CrossElectronics closed 1 year ago

CrossElectronics commented 1 year ago

GregTech CEu Version

v2.4.1-beta

Modpack Used

Nomifactory CEu Edition 1.4

Addons Installed

No response

Environment

Singleplayer

New Worlds

Unsure

Cross-Mod Interaction

Unsure

Expected Behavior

Both miners should be able to collect ore blocks and only ore blocks from their respective working area

Actual Behavior

image survival, roof of nether: The miner placed down first is working properly while the other is constantly collecting cobblestone. Note that there are no cobblestone / stone in nether. If anything it should be netherrack.

image creative, overworld: The miner placed down first is working properly while the other is collecting mostly cobblestone

Steps to Reproduce

1) Install two miners close by and power them 2) Observe the miners

Additional Information

Is it because the latter miner is trying to mine the block that has already been mined i.e. air cobblestone? Since the miner logic replaces the already mined block with cobble to prevent mob from spawning.

Might be related: https://github.com/GregTechCEu/GregTech/blob/d9b92f3252a1c43b7a362d4f4e1e12b9f382d951/src/main/java/gregtech/api/capability/impl/miner/MinerLogic.java#L138-L146 https://github.com/GregTechCEu/GregTech/blob/d9b92f3252a1c43b7a362d4f4e1e12b9f382d951/src/main/java/gregtech/api/capability/impl/miner/MinerLogic.java#L238-L249

lordclips commented 1 year ago

I'll fuck around with this one and find something out