search

GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
226 stars 170 forks source link

Rework Voiding Covers #1414

Closed ghzdude closed 1 year ago

ghzdude commented 1 year ago

What

Adds a toggle button for enabling/disabling the voiding cover in its UI. Also aims to fix #1440. Improves Soft Hammer functionality by sending a message to the player when enabled or disabled. Adds swinging animation when using wrench on an applicable pipe.

Implementation Details

Added a CycleButtonWidget() to the GUI to invert isWorkingAllowed on all voiding covers. Added hand paramater for onPipeToolUsed(). Added check for Soft Mallet in BlockPipe.java. Remove overrides of onSoftHammerClick() in Advanced Voiding Covers.

Outcome

Users can access the GUI to enable the cover, along with configuring other cover settings. Users are appropriately notified when a Voiding Cover is enabled via Soft Hammer. Fixes #1440. Users arm swing when using a Wrench on a compatible pipe

Additional Information

image image image image

Potential Compatibility Issues

None, as far as I know.

brachy84 commented 1 year ago

What the fuck are those UI's? :doom:

ALongStringOfNumbers commented 1 year ago

Now that you reimplemented the soft mallet clicking for activation, could you fix #1440 in this PR as well?

LAGIdiot commented 1 year ago

@ghzdude you should update your opening comment as you change PR as right now it is quite misleading

LAGIdiot commented 1 year ago

After last batch of commits there seems to be graphical glitch: image

ghzdude commented 1 year ago

GUI issue should be fixed in https://github.com/GregTechCEu/GregTech/pull/1414/commits/210d36203595e75ae09aa3c69a2fac4d9b5fd1f0.

LAGIdiot commented 1 year ago

Switching from Void Matching to Void Overflow makes whitelist/blacklist button disappear. Not sure if it is intended or if it was broken before this PR.

image image

LAGIdiot commented 1 year ago

Switching from Void Matching to Void Overflow makes whitelist/blacklist button disappear. Not sure if it is intended or if it was broken before this PR.

If it is either then there is no need to fix it.

LAGIdiot commented 1 year ago

Otherwise it looks completed.

LAGIdiot commented 1 year ago

Switching from Void Matching to Void Overflow makes whitelist/blacklist button disappear. Not sure if it is intended or if it was broken before this PR.

If it is either then there is no need to fix it.

I check it out and it was already in, so there is no need to do anything with it.