search

GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
239 stars 179 forks source link

Crash when adding cover to machine on an unvalkyried heavens ship #1505

Closed Homssu closed 1 year ago

Homssu commented 1 year ago

GregTech CEu Version

2.5.0-beta

Modpack Used

No response

Addons Installed

No response

Environment

Singleplayer

Side Crashed

Client

New Worlds

Yes

Steps to Reproduce

  1. Build a platform in the air
  2. Add a physics infuser
  3. Place down an LV macerator
  4. Assemble the ship
  5. Try to add a cover to the LV macerator
  6. Crash

Crash Report

https://pastebin.com/ZyZiV2Em https://pastebin.com/P53P7frb

Additional Information

Unvalkyried Heavens version 1.0.9

LordDarthDan commented 1 year ago

Why would it return null? Valkyrien simply transforms the raycast vector from world pos to ship pos:

https://github.com/LordDarthDan/Unvalkyried-Heavens/blob/master/src/main/java/org/valkyrienskies/mixin/client/MixinMinecraft.java

It only transforms the target position though, so in reality you get a very long vector from player at -100 -600 to ship at 5120000 0...

TechLord22 commented 1 year ago

This should be fixed as of #1507.