search

GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
252 stars 177 forks source link

Items inside Crafting Station can be moved while scrolling through the inventory tab #1675

Closed mateskr692 closed 1 year ago

mateskr692 commented 1 year ago

GregTech CEu Version

2.5.4

Modpack Used

Nomifactory CEu

Addons Installed

No response

Environment

Singleplayer

New Worlds

Yes

Cross-Mod Interaction

No

Expected Behavior

When switching to the inventory tab you shouldn't be able to accidentally pull out items/tools from crafting station while scrolling

Actual Behavior

While scrolling through the inventory tab it is possible to extract items and tools out of the crafting station. It is because the scroll is conveniently used as 'take 1 / deposit 1' shortcut. This leads me to believe that the inventory tab renders on top of the the previous tab, having them overlap and making it possible to interact with the items you're not even seeing.

This also works with other tabs than just the storage. Checking a recipe in JEI still lets you interact with the Crafting Station, causing you to accidentally extract items, or select a recipe from saved recipes when trying to use the "+" button (move items).

Steps to Reproduce

  1. Place a crafting station and put some items/ tools inside image
  2. (optional) Place a chest next to the crafting station and fill it with items
  3. switch to the Storage tab in crafting table and hover over a spot that overlaps with an item in the Crafting tab. For example 1st item in 3rd row is in the same place that the 1st tool slot in the crafting tab image
  4. Use scroll down. This causes the tab to scroll down to show other items (as expected) but also takes out the item from the Crafting slot (not intended). In this example notice that after scrolling a screwdriver is now in my inventory and after switching to the Crafting tab the tool in first slot is indeed empty image image

Similarly its possible to extract items while in JEI tab:

  1. Hover over some item image
  2. Press R to open JEI recipe tab (dont move your mouse) image
  3. Scroll down a little and come back to the crafting station, the items that you were hovering on got extracted image

For the conflict with JEI crafting recipe:

  1. Craft some items so they are in the history to the right and clear the crafting grid image
  2. Open JEI and Press the "+"button to move the items. In my case the button to move items for iron block is in the same spot as 6th saved recipe so after clicking it instead of moving items to make iron block it clicked the recipe in history to craft iron rod image image

Additional Information

No response

zhwith commented 1 year ago

This is a known issue with Mouse Tweaks, setting the scroll handling config to 0/non-smooth fixes it.

mateskr692 commented 1 year ago

This is a known issue with Mouse Tweaks, setting the scroll handling config to 0/non-smooth fixes it.

I disabled it and indeed, it fixed the issue with JEI, however the first problem I described with taking out items from Storage tab while scrolling still remained

mateskr692 commented 1 year ago

I made a fresh install with just the GTCEu and this problem doesn't occur anymore, so you're right it's a Mouse Tweaks issue