GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
237 stars 178 forks source link

Ender Fluid Link Cover desync in LAN #2042

Open RhenaudTheLukark opened 1 year ago

RhenaudTheLukark commented 1 year ago

GregTech CEu Version

2.6.2

Modpack Used

Nomifactory CEu edition

Addons Installed

No response

Environment

Multiplayer on LAN

New Worlds

Unsure

Cross-Mod Interaction

No

Expected Behavior

All covers set up by either me or my partner should be synced up at all times if they're all in public mode.

Actual Behavior

Whenever my partner changes a channel on an Ender Fluid Link Cover, it seems that all covers I have set up myself are desynced from that cover, as if the covers were on private mode despite being on public mode.

Steps to Reproduce

Unfortunately, this error seems to happen weirdly, we do not have the exact reason as to why it does not work. We tried reproducing the steps below, but it seems following them doesn't lead to the bug on a fresh cover channel... However, we can try to give insight as to what seems to happen. Hopefully that's enough.

  1. Player 1 setups a cover with a given channel, on public mode (the button has never been pressed, if that matters) and pushes liquid in it.
  2. Player 2 setups another cover with the same channel, on public mode as well (button not pressed).
  3. The channel set up by the other player should not have any liquid.

For info, said channels can be anything. We have this case happen for example on channels F000001D or even 00000017. We use two covers connected to an Super Tank, with liquid input channels labelled following the rule F000XXXX (with X being a number), and output channels labelled following the rule 0000XXXX.

Additional Information

This is likely caused because covers seem to be in private mode by default, as whenever I reset the channel of the cover, it syncs back up with all the cover I have personally set up. However, as we weren't easily able to reproduce the problem, it's only speculation.

IntegerLimit commented 1 year ago

Original Post Here.

RhenaudTheLukark commented 1 year ago

On top of that, here is the server folter related to the instance in which we've had this problem. It uses Nomifactory CEu 1.6.1 beta 4. It contains two examples of such behavior, on the channels F0000064 and F0000065. The covers related to said channels are in those coordinates:

F0000064:

F0000065:

These covers are in different dimensions, but the problem has happened with all covers being in the Overworld, so it shouldn't pertain to this problem. If you need anything else from me, feel free to reach out!

RhenaudTheLukark commented 1 year ago

Update: We discovered that the issue comes from the Chunk Loading Ward from Extra Utilities 2. We were chunk loading the areas with both FTB Chunks and the Chunk Loading Ward from Extra Utilities 2, which would break the liquid ender covers over and over again. I don't know if this issue still pertains to GregTech, but it might be a good idea to add a safeguard for this if possible?

IntegerLimit commented 1 year ago

Update: https://github.com/Nomi-CEu/Nomi-CEu/issues/410#issuecomment-1694036912. Apparently may happen in singleplayer too.