GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
223 stars 166 forks source link

Fix LCE/ECE from parallelizing too much #2426

Closed ghzdude closed 1 month ago

ghzdude commented 1 month ago

What

fixes an issue where the LCE/ECE would parallelize too much because getMaxParallelVoltage() used getMaxOverclockVoltage() which was not overridden in the LCE's workable handler

origin of this issue probably came from #2390

Implementation Details

override getMaxOverclockVoltage() to return getMaxVoltage in the workable handler

Outcome

a proper amount of fuel consumption and energy production

serenibyss commented 1 month ago

Is this change also relevant for large turbines? If so it may be better to put this override in the fueled multiblock controller class to potentially fix issues with other mod implementations of the class

ghzdude commented 1 month ago

Is this change also relevant for large turbines? If so it may be better to put this override in the fueled multiblock controller class to potentially fix issues with other mod implementations of the class

large gas turbines aren't affected, since they handle their recipe logic differently. moving the change up into the fueled recipe logic class would probably be a good idea.