Previously, in Supersymmetry, there were several blocks in JEI previews that were rotated variants of the original block shown in JEI searches. However, the toItem method used to retrieve the stack for the item requirement list did not take this into account, and used the rotated variant rather than the normal item. For example, if rotated wooden logs were placed into a multiblock structure, missing item textures would appear:
Implementation Details
I've mitigated this issue by prioritizing the pickBlock method within the stack retrieval algorithm, allowing blocks such as wooden logs to have more of a "say" in what meta is applied.
Although the original comment states that pickBlock is "not great," analyzing the code shows that it has nearly the same method calls as GTUtility's toItem, with the GregFakePlayer call being cached after its first use.
Outcome
Allows blocks from addons to return the correct item stack for multiblock previews.
Potential Compatibility Issues
In the case that a specific multiblock from an addon added special code to pickBlock that wouldn't apply to multiblock previews for some reason, that might cause a problem, but I find it unlikely.
What
Previously, in Supersymmetry, there were several blocks in JEI previews that were rotated variants of the original block shown in JEI searches. However, the
toItemmethod used to retrieve the stack for the item requirement list did not take this into account, and used the rotated variant rather than the normal item. For example, if rotated wooden logs were placed into a multiblock structure, missing item textures would appear:Implementation Details
I've mitigated this issue by prioritizing the
pickBlockmethod within the stack retrieval algorithm, allowing blocks such as wooden logs to have more of a "say" in what meta is applied. Although the original comment states thatpickBlockis "not great," analyzing the code shows that it has nearly the same method calls as GTUtility'stoItem, with the GregFakePlayer call being cached after its first use.Outcome
Allows blocks from addons to return the correct item stack for multiblock previews.
Potential Compatibility Issues
In the case that a specific multiblock from an addon added special code to pickBlock that wouldn't apply to multiblock previews for some reason, that might cause a problem, but I find it unlikely.