GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
223 stars 166 forks source link

Bloom layer cannot be handled by Vintagium (Sodium 1.12), causing crash on world load #2462

Closed NostalgicLorikeet closed 1 week ago

NostalgicLorikeet commented 2 weeks ago

GregTech CEu Version

v2.8.7-beta

Modpack Used

No response

Addons Installed

No response

Environment

Singleplayer

Side Crashed

Client

New Worlds

Yes

Steps to Reproduce

  1. Install Vintagium and GregTech together
  2. Load world

Crash Report

Additional Information

Vintagium can be downloaded here (not on curseforge)

GTCEu crashes the game alongside Vintagium because of the bloom it adds to certain blocks (although it crashes the game no matter what blocks are in the world, this was tested on a void superflat world)

This class is the one mentioned in the crash report. Vintagium can handle the SOLID, CUTOUT_MIPPED, CUTOUT, and TRANSLUCENT layers, but cannot do so for the "Bloom" layer added by GT.

According to Vintagium's dev, the problem lies here on your end

This issue has been reported to the developer of Vintagium, however they have indicated it is an issue on your end.

htmlcsjs commented 2 weeks ago

There would have to be support for adding other render layers in this, we can hack it apart on GT's end but adding more extensible support here would be better imo. I will try and fix the crash by straight up disabling bloom if this is installed with GT in the mean time, (we currently do something similar with optifine)

NostalgicLorikeet commented 2 weeks ago

Thanks! I was looking forward to using the bloom lights, but it's nice to see a fix that could make the two compatible in the meantime. Looking thru Vintagium's code it seems like they intend on adding a better implementation for render layers based on code comments.

htmlcsjs commented 2 weeks ago

The fix does allow bloom to fully work, its more of that its using ASM and reflecting stuff, instead of a nice api on vintagium's end

NostalgicLorikeet commented 2 weeks ago

When I compile and add this to my pack there are some problems that seem to be caused by dependencies. Have any new dependencies been added since the last released version?

kumquat-ir commented 2 weeks ago

There is unreleased work (the ui rework) on the master branch that adds a couple new dependencies (modularui and mixinbooter) and hasnt been in any releases yet since its not done yet.

NostalgicLorikeet commented 2 weeks ago

I have both installed but I still get a crash image image (happens even with the minimum needed mods installed, not sure what I'm doing wrong)

htmlcsjs commented 2 weeks ago

a) i think you used the deobfiscated, developer build of the mod instead of the proper build used with forge, at least with the minimal crashlog you provided b) here is a building of gt that is just 2.8.7 with the patch cherrypicked in, you do not need ModularUI and Mixinbooter for this build

NostalgicLorikeet commented 2 weeks ago

Yeah, it had -dev in the filename but it was the only jar i could find that compiled. Also I was given that in the Discord, thanks!