GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
255 stars 176 forks source link

Change bloom layer to use mixin instead of enumHelper #2583

Closed MCTian-mi closed 6 days ago

MCTian-mi commented 3 months ago

What

As the title says.

Implementation Details

Adds two mixins targeting BlockRenderLayer.class, BlockRenderPass.class and ChunkRenderPass.class, adding the bloom layer during initialization.

Outcome

This fixes issues with EnumMaps, like https://github.com/embeddedt/VintageFix/issues/112 . ↑ it doesn't, after I cleaned up the workplace and run client again, weird. But ig this PR is still fine as a refactor.

Additional Information

I've also tried to get Nothirium patch using mixin, but I'm still waiting for auther's reply since it's gonna use some codes from Nothirium but it's ARR licenced. The Nothirium compat now uses mixin as well. Thanks to @Meldexun for allowing me to use some of Nothirium code here!

For Vintagium I failed to get mixin work and idk why 😢. ↑ nvm I figured it out.

Potential Compatibility Issues

None that I can think of?