GregTechCEu / GregTech

GregTech CE 1.12 fork continuing progression and development
GNU Lesser General Public License v3.0
254 stars 176 forks source link

Update MUI2 dep to RC2 #2622

Open ghzdude opened 2 months ago

ghzdude commented 2 months ago

What

updates mui2 dep to rc2 ports multi fluid tank hatches to mui2 to test our fluid slot impl port single take fluid hatches to test fluid locking fixes issues in mui2 via mixin

Implementation Details

new Row() -> Flow.row() new Column() -> Flow.coloumn() GuiData is now passed in to mui methods instead of main panel reworks abstract ender cover ui because extending PanelSyncHandler is no longer desirable FixedFluidSlotSH has been merged with GTFluidSlotSyncHandler Tooltip is deprecated and replaced with RichTooltip and other stuff

need to check these things to make sure they still work

Outcome

another step for the road to mui2

ghzdude commented 2 months ago

The Ghost Circuit shift-click selector popup doesn't seem to work. No panel is created when shift left clicking.

In the Ender Fluid Link Cover, when a Fluid Filter is added, if you open the fluid filter settings, you cannot drag the panel when you click on the title (TextWidget), you can only drag the panel when clicking on the actual panel. This is not that great, as the panel is a bit small, and filled with things that block you from dragging it. (This was possible in RC1, so something changed, either on MUI end or in this PR).

In addition, once you start dragging the panel, you cannot stop dragging the panel. Clicking anywhere with the panel when it is being dragged does not park the panel in the clicked location.

No tooltips are present on any of the buttons, except for the lock button and the entry selector, in the Ender Fluid Link cover GUI, though I cannot remember if this was the case before this PR

When dragging a panel, you can still pick up items out of your inventory onto your mouse cursor. This probably should not be allowed.

these are all things that should be fixed in MUI2

You can no longer shift click to open covers when they are your selected item

I'm able to open the filter ui when right clicking with a filter selected in the hotbar, but that functionality was never implemented for other covers so idk what you mean exactly. Shift right-clicking prevents the ui from being opened so the NBT can cleared.

A lot of buttons feel like they are missing tooltips when they previously had tooltips.

already fixed in mui2 dev

Something is going wrong with the Multifluid hatches. I clicked a stack of 45 cells into a multifluid input, all fluid went it. I tried to grab the fluid back with the 45 cells, and only 44 cells were filled. I could repeat this several times. I then closed the GUI and reopened it, tried clicking on the 1 B of fluid with a cell, but it deleted itself.

this is now fixed

ghzdude commented 1 month ago

this pr is on hold and should not be merged until mui2 rc3 or later is released

ghzdude commented 2 weeks ago

I've decided to fix the issues with MUI2 via mixin, so that this pr doesn't need to wait for the next mui update and to fix issues with other/future mui2 port prs. This pr can be looked at now.