GregTechCEu / gregicality-legacy

GNU General Public License v3.0
41 stars 58 forks source link

Gregicality + TConstruct Fluids w/ Missing Textures & Placeability Issues #223

Open Brittank88 opened 3 years ago

Brittank88 commented 3 years ago

Some native GTCE fluids, and fluids added by Gregicality when TConstruct is present, can be placed in the world. Prior to Gregicality being present, the native GTCE fluids are not placeable in the world (and of course the other fluids don't exist).

When these fluids are placed into the world they have the placeholder missing textures... texture. You know what I mean 😛.

Furthermore, some fluids are completely invisible when inside of a fluid tank. For testing purposes I am using Openblocks tanks to determine which fluids have this issue, and have come up with a list of all the GTCE / Gregicality + TCon fluids that are affected. I basically used CraftTweaker to generate a setblock command for each fluid type (in an openblocks tank) and ran all those commands from an mcfunction file.

This list should cover all the fluids that are placeable and have missing textures (checkerboard in world, invisible in tank), or not placeable and have missing textures (invisible in tank).

Please let me know if any more information is needed!

huneau commented 3 years ago

thx for this issue @hjae78 its me or all fluid comes from us with the new fluid method ?

hjae78 commented 3 years ago

Looks like only fluids from new fluid method

Brittank88 commented 3 years ago

By the way, in case somehow this proves useful in future, my CrT script to generate commands for all present game fluids placed as openblocks tanks is this:

var x = 0;
var y = 0;

for liquid in game.liquids {
    print("execute @a ~ ~ ~ setblock ~" + x + " ~" + y + " ~ openblocks:tank 0 destroy {tank:{FluidName:\"" + liquid.name + "\",Amount:16000}}");
    y += 1;
    // Adjustable max height for columns of tanks. Make sure you're greater than this value under the max build height!
    if (y > 64) {
        y = 0;
        x += 1;
    }
}

This will print to crafttweaker.log all the commands you need to paste in the .mcfunction file - you just need to remove the [INITIALIZATION][CLIENT][INFO] prefix CrT's logger adds to each line.

Can then simply run the function file in-game to generate a wall of all fluids in openblocks tanks at your location.