Gregicality multiblocks using old metal casing

[ivelieu]

I'm on Gregicality skyblock edition version 6.1, which is using Gregicality-1.12.2-0.23.1. I can't find any previous mention of this issue, and to be honest I am not sure if the issue belongs here or on https://github.com/GregTechCEu/gregicality-multiblocks/pulls (which I found from a link in the description of the gregicality bugs channel on the GTCEu discord)

The casings for the large miner and advanced large miner are using the old casing types with no recipe. They should be using the "Sturdy HSS-G" and "Rigid HSS-S" casings. It seems that they were missed for edits or not existing at the time of #507, maybe this is where it was missed: https://github.com/GregTechCEu/gregicality/pull/507#pullrequestreview-717326252

The "Basic Large Miner" does have the correct "Rugged black steel casing" though.

[TechLord22]

I believe the latest version of that modpack, Gregicality Skyblock Edition 6.3, has an updated version using Gregicality-1.12.2-0.23.3. In that version, the casings used are correct. Let us know if updating does not fix this.

[ivelieu]

Github GSE newest is 6.1. I'm 90% sure whoever uploaded to curseforge did different versioning. Which I can say has caused me a lot of confusion >_<

Curseforge 6.3 is older than github 6.1.

https://github.com/GregTechCEu/gregtech-skyblock-edition/releases

https://www.curseforge.com/minecraft/modpacks/gregicality-skyblock-edition/files

Here I make a fresh download of GSE 6.3 via curseforge in multiMC and we can see it uses the same version Gregicality-1.12.2-0.23.1

I will also mention I did check Gregicality 1.12.2-0.23.2 and 1.12.2-0.23.3 patch notes before making this post. They do not list anything about the casings getting fixed.

Just in case what you were saying is right aside all of that, I have made a new instance of the github GSE 6.1 and replaced the gregicality jar to 1.12.2-0.23.3. Indeed the issue still persists with the updated version.

[TechLord22]

Okay honestly this is pretty funny. I'll see if updating Gregicality locally will fix that (and not cause problems), and if so, will push an update to the modpack accordingly.

[TechLord22]

I have released a new version of Gregicality Skyblock Edition on github: https://github.com/GregTechCEu/gregtech-skyblock-edition/releases/tag/6.4

This updates Gregicality to the latest release, and additionally fixes the issue with the miners.

[ivelieu]

Thank youuuu ❤️ all fixed~

[ivelieu]

So, I didn't think of it at the time, but advancing further I realised some other multiblocks have the same issue. I looked through all the multiblocks in gregicality to check. There are three others: the large extruder, large packaging machine and large wiremill.

I was hoping to fix the issue myself after seeing how @TechLord22 did it, I spent some time looking at gregicality\src\main\java\gregicadditions\GAConfig.java and gregtech-skyblock-edition/config/gtadditions.cfg and was feeling very puzzled. Although I was not able to work it out, I did notice some typos in the config comments.

https://github.com/GregTechCEu/gregicality/blob/fc7068ee70a7973f379b326aa7578c366f9f7fd2/src/main/java/gregicadditions/GAConfig.java#L772 https://github.com/GregTechCEu/gregicality/blob/fc7068ee70a7973f379b326aa7578c366f9f7fd2/src/main/java/gregicadditions/GAConfig.java#L862 https://github.com/GregTechCEu/gregicality/blob/fc7068ee70a7973f379b326aa7578c366f9f7fd2/src/main/java/gregicadditions/GAConfig.java#L893

[ivelieu]

I found the fix ✨

I also make a pull request here to update the documentation generator for gtadditions.cfg. I don't know how to compile the gtadditions.cfg file from the GAConfig.java annotations but I tried to edit both to make them line up.

I do kind of wonder why HG-1223 casing is prefixed "toxic", I mean, it's only used for a packager, I'm not sure I want all my little dusts rubbing onto toxic casings. 😝

[TechLord22]

This is now fixed in the latest release, as the old casings no longer exist.