search

GregYankovoy / vue-cli-plugin-bootstrap-vue

vue-cli 3 plugin to add bootstrap-vue
MIT License
34 stars 2 forks source link

Option to allow use a scss config #23

Closed fech-dev closed 3 years ago

fech-dev commented 3 years ago

This adds the possibility to have an scss scaffold instead of a simple css. It creates two files in ./src/assets/scss/vendors/bootstrap-vue folder, _custom.scss & index.scss. In _custom.scss are present both variables of bootstrap and bootstrap-vue, in index.scss are present all bootstrap/bootstrap-vue code.

The imports are changed, the bootstrap-vue plugin remains the same, the css imports are removed, the scss import of vendors/bootstrap/index.scss is added to the App.vue file in the style block, the scss variables are placed in the sass-loader option's additionalData (this expose bootstrap variables to all vue components).

Should resolve issue #4.

GregYankovoy commented 3 years ago

Thanks for the contribution! Give me a bit to review this.

fech-dev commented 3 years ago

@GregYankovoy Hi, any news about the review/merge and release? thanks

GregYankovoy commented 3 years ago

@fech-dev Taking a look at this tonight. Will leave any questions/comments I have in this thread

fech-dev commented 3 years ago

Hi, can I have a "release date" of this functionality? My team would like to use it as soon as possible... Thanks

GregYankovoy commented 3 years ago

@fech-dev Thanks for the contribution. I have merged and versioned up to 0.8.0. It should be pushed to npm as of a few minutes ago.