search

Gregor-Agnes / newsletter_subscribe

TYPO3-extension: Subscribe and unsubscribe to tt_address, generate static Link to unsubscribe (to use in Newsletter), automatically delete unconfirmed subscribers
https://extensions.typo3.org/extension/newsletter_subscribe
GNU General Public License v3.0
2 stars 5 forks source link

Configuration issues #46

Closed SicorDev closed 2 years ago

SicorDev commented 2 years ago

Hi guys!

Great extension, albeit I'd have a few suggestions to improve configuration for TYPO3 10 and onwards.

I spent quite some time to figure out some typoscript settings:

1. config.language = de config.locale_all = de_DE.utf8

=> Instead of relying on otherwise superfluous config.language entries, try auto detecting the info from the request. Code might work like that:

$requLanguage = $GLOBALS['TYPO3_REQUEST']->getAttribute('language');
$langid = $requLanguage ? substr($requLanguage->getHrefLang(), 0, 2) : "de";

2. plugin.tx_newslettersubscribe.settings.subscribePageUid = 1397 plugin.tx_newslettersubscribe.settings.mailTemplateRootPath = EXT:newsletter_subscribe/Resources/Private/Templates/Mail/

=> Both are required for "unsubscribe", but can neither be configured via constants nor are they present in the plugin. Actually I don't see any constants at all in my installation, which feels like an error? Not sure...

Anyway, carry on with the good work and Happy Holidays!

Gregor-Agnes commented 2 years ago

Thx, I will look into it in the next release!

Gregor-Agnes commented 2 years ago
  1. This is fixed in 02024f05cc543fcb26ad9a3975f62f303211d83d
  2. Those are used in the templates and defined in setup.typoscript