search

GregorCH / ipet

Interactive Performance Evaluation Tools for Optimization Software
MIT License
26 stars 6 forks source link

Reductionindex for columns #43

Closed GregorCH closed 7 years ago

GregorCH commented 7 years ago

closes #21 #31

GregorCH commented 7 years ago

@fschloesser , I created new tests for all the questions you raised in your review. In particular, I test that Filter Data survives the reduction process.

We should merge this soon and fix bugs later.

fschloesser commented 7 years ago

I agree, we should merge this soon.

GregorCH commented 7 years ago

Are there any further questions from your side that I haven't addressed yet?

fschloesser commented 7 years ago

Everything looks fine, you are satisfied with the current status, then you should just merge it.