Gregory365 / TPF2-Timetables

The Timetable mod for Transport Fever 2
GNU General Public License v3.0
13 stars 5 forks source link

Recent Update made the train no longer able to depart #58

Closed flyrobot27 closed 9 months ago

flyrobot27 commented 1 year ago

I am having issue with the recent "force depart" update. The trains no longer departs the station and causing massive train jam. This happens on both the lines set for auto unbunch and a timetable. The save game was running an older version of this mod. I still have the save game and it will be great if you can look into this.

Steps to reproduce:

Create a game with older version of this mod (before the force departure update).

Create a line. Set a auto unbunch or something. Let the game to run for a while.

Update the save game with the current version of this mod.

You will notice that trains will randomly stopped departing, or the trains will depart immediately.

Gregory365 commented 1 year ago

Unfortunately, I can't reproduce this issue with the information provided. Could you upload the sav.lua file for that save?

flyrobot27 commented 1 year ago

For sure, here is the save.lua file:

autosave_Linear Island_2192-10-14.sav.lua.zip

If you need other files please let me know

flyrobot27 commented 1 year ago

Have you managed to make any progress with this issue?

Gregory365 commented 12 months ago

I still haven't been able to reproduce this using the steps provided. One issue I did find was that only Unbunch & AutoUnbunch using multiple platforms doesn't work as expected (two vehicles will depart at the same time, rather than consecutively), but I was also able to reproduce this issue in v1.3.2 as well. Let me know if you think this is the issue you are facing.

Having looked at the sav.lua, it looks like this issue may be related to #55, which has been fixed in the develop branch. Could you use the develop branch of this mod to see if that solves the issue?

If not, you will need to be more specific about "randomly departing". Give one specific scenario with the timetable slot (or unbunch time or margin time), the time you expect the vehicle to depart and the actual arrival time & actual departure time.

flyrobot27 commented 11 months ago

Okay, it seems that the developer version seems to have fixed this issue. I will still need to run the game for a couple of hours to confirm it is fine. Thanks for the update

flyrobot27 commented 11 months ago

Hi, sorry but it seems that the problem still exists. I checked the log and I still get a lot of "Timetables failed to resume dead coroutine". The error is thrown at line 657 of the timetable.lua file: attempt to index "VehiclesWaiting (A Nil value)".

I am on the development build, pulled around 2 days ago. This is the full save lua file: Fail.sav.zip

Gregory365 commented 11 months ago

Thanks for the report. I have pushed a fix to the develop branch. That issue would have been quite rare, so there is probably still an underlying issue. Please continue to report any other errors you get from the log.

Gregory365 commented 9 months ago

Fixed in v1.3.5