search

Gregory365 / TPF2-Timetables

The Timetable mod for Transport Fever 2
GNU General Public License v3.0
13 stars 5 forks source link

Stability fix #75

Closed MarkMcWire closed 2 weeks ago

MarkMcWire commented 1 month ago

Fixes the memory leak from Version 1.3, so the game don't crash. But the mod still needs 20 GB of additional RAM on Linux.

Gregory365 commented 1 month ago

Over 3000 lines changed!?

Gregory365 commented 1 month ago

Can you split the whitespace refactor and the memory leak fix, at least into separate commits so I can review what has been changed? Thank you for looking into this issue, it's been bugging me for months.

MarkMcWire commented 1 month ago

Can you split the whitespace refactor and the memory leak fix, at least into separate commits so I can review what has been changed? Thank you for looking into this issue, it's been bugging me for months.

How? My editor automatically converts spaces to tabs. I basically only work with tab stops because that's what I'm used to from Python.

Gregory365 commented 1 month ago

Ok nvm, TIL a way view the changes ignoring the whitespace by appending '?w=1' to the end of the URL https://github.com/Gregory365/TPF2-Timetables/pull/75/files?w=1

Gregory365 commented 1 month ago

I've put a request in the timetables discord server for people to test this branch. I'll wait for feedback from that test before merging this in and pushing the update to steam workshop.