search

GregoryLand / Lorei

Lorei
MIT License
3 stars 0 forks source link

Scripts should be organized into subfolders #6

Open GregoryLand opened 10 years ago

GregoryLand commented 10 years ago

Scripts should be organized by language. May be worth white to setup recursive checking of sub folders. This way we can organize scripts into logical units.

SkySom commented 10 years ago

I think leaving it as it is and just using what I'm using to get all the programs from the Start Menu. 

String[] pythonFiles = Directory.GetFiles("Scripts", "*.py", SearchOption.AllDirectories); //Returns all Python Files

It would allow use to even pull certain file patterns (Think like "Main" for it certain which would allow to add supporting multi-file scripts but still only call the main file to register.

GregoryLand commented 10 years ago

So are we just going to keep dumping all the scripts into this directory? What do we do when we have obvious modules for things like google cal and gmail? It would be nice to have things organized so we can turn on and off features by excluding or including directories.

GregoryLand commented 10 years ago

If we do it with simple directories we can create a basic package manager that grabs scripts you want from the git repo.

GregoryLand commented 10 years ago

And thinking more on it we could have each module have an XML doc in it that we could load. This info would let us know what scripts to add or remove to turn on or off specific features

SkySom commented 10 years ago

I was actually thinking the same... But in some cases I think it may be a bit overkill for some scripts. The simpler ones. But I do like the idea. We will have to make it as easy as possible as to not make it an exercise in futility.

GregoryLand commented 10 years ago

right. I was thinking alot of the simpler ones like the program scripts should actually get bundled into a module together. with the XML you can go through and pick the programs that you use to get more features for them.

So we would have a module selection area. there would be a checkbox for "Program Control" say. It would download the xml for that module and based on whats in the xml display the configurable options for that program. In this case it would list the programs supported. It may even be better to run a script that lets the module configure itself. Display whatever dialog boxes it needs to the user and so on.

On Sun, Jan 5, 2014 at 6:20 PM, Skylar Sommers notifications@github.comwrote:

I was actually thinking the same... But in some cases I think it may be a bit overkill for some scripts. The simpler ones. But I do like the idea. We will have to make it as easy as possible as to not make it an exercise in futility.

— Reply to this email directly or view it on GitHubhttps://github.com/GregoryLand/Lorei/issues/6#issuecomment-31618996 .

GregoryLand commented 10 years ago

If we use a script then program control module could look in the file system and find programs that it knows you have and suggest downloading those scripts by default. I don't see a reason that python couldn't do this for us.

On Sun, Jan 5, 2014 at 6:24 PM, Greg Land landjgregory@gmail.com wrote:

right. I was thinking alot of the simpler ones like the program scripts should actually get bundled into a module together. with the XML you can go through and pick the programs that you use to get more features for them.

So we would have a module selection area. there would be a checkbox for "Program Control" say. It would download the xml for that module and based on whats in the xml display the configurable options for that program. In this case it would list the programs supported. It may even be better to run a script that lets the module configure itself. Display whatever dialog boxes it needs to the user and so on.

On Sun, Jan 5, 2014 at 6:20 PM, Skylar Sommers notifications@github.comwrote:

I was actually thinking the same... But in some cases I think it may be a bit overkill for some scripts. The simpler ones. But I do like the idea. We will have to make it as easy as possible as to not make it an exercise in futility.

— Reply to this email directly or view it on GitHubhttps://github.com/GregoryLand/Lorei/issues/6#issuecomment-31618996 .

SkySom commented 10 years ago

Well creating a GUI Setting should be too hard. So we could do that, and use the xml's as defaults and config storage. Not quite sure about bundling the scripts. And couldn't this be added to the AllProgramsProcessor? Already had knowledge of all programs. I mean. What if someone hasn't that script? That is my biggest problem with using Scripts for stuff like that. We have to base stuff like that on having no scripts. Since we can't always expect that it can access the scripts.

GregoryLand commented 10 years ago

We could always bundle a set of scripts by default that would cover a lot of usecases. The AllProgramsProcessor really makes more sense as a script, inside of the Program Control package, from my viewpoint. What AllProgramsProcessor does is actually something I find undesirable myself. I think its cool that we can do it but I am kind of sick of Lorei launching paint every time she misunderstands me or i yell at my cat to get off the table.