Gregwar / Captcha

PHP Captcha library
MIT License
1.73k stars 290 forks source link

Why Finder 3.0 ? #64

Closed ghost closed 6 years ago

ghost commented 6 years ago

Is there anything that prevents it from working with Finder 2.8?

I am using this package through gregwar/captcha-bundle, which will work with Symfony 2.8. However, gregwar/captcha requires Finder 3.0 or above. As the result, I get gregwar/captcha v1.1.3 which is not compatible with PHP 7, while Symfony 2.8 is.

Gregwar commented 6 years ago

I agree that this dependency could be loosened, maybe even to a star since we only use the very core of the finder in a really specific function

Gregwar commented 6 years ago

I loosened the dependency and tagged v1.1.7, is it ok for you?

ghost commented 6 years ago

That would definitely work. Already updated.

Thank you for prompt response!

ZhangChengLin commented 3 years ago

Now what?

https://packagist.org/packages/symfony/finder#5.3.x-dev

5.3.x-dev  2021-08-04 21:20 UTC
requires

php: >=7.2.5
symfony/polyfill-php80: ^1.16