search

Gregwar / CaptchaBundle

Symfony bundle implementing a "captcha" form type
MIT License
345 stars 127 forks source link

Fully support Symfony 4 and 5 #208

Closed Olaf1989 closed 4 years ago

Olaf1989 commented 4 years ago
Gregwar commented 4 years ago

Hello,

Can you explain what standard you are using to reformat the whold code?

For example, as specified in PSR-12, binaries operator should be surrounded by spaces, and your commit removes the spaces around the concatenation operator: https://www.php-fig.org/psr/psr-12/#62-binary-operators

Thank for your work

Gregwar commented 4 years ago

Ok, just realized Symfony coding standard are not respecting PSR-12, since it it saying otherwise here: https://symfony.com/doc/current/contributing/code/standards.html#structure

Olaf1989 commented 4 years ago

@Olaf1989 looks for me this table is not correct as it seems 2.1 which does support symfony 4 and 5?

You are right, I expected to go up a major version. I see that you have already created a pull request.

Gregwar commented 4 years ago

I accepted the PR to fix the table, however I am open to any suggestion if you think it makes mor sense to tag v3.0.0 for e.g.