CaptchaType

[gerMdz]

deprecation

Symfony 5.4.1 gregwar/captcha-bundle: 2.1.5

Since symfony/framework-bundle 5.3: The "session" service and "SessionInterface" alias are deprecated, use "$requestStack->getSession()" instead. It is being referenced by the "gregwar_captcha.type" service.

Hi. Is there a way to fix it without touching the vendor class?

[Gregwar]

Hello This is done, tagged v2.1.7

[Gregwar]

Thanks for reporting

[gerMdz]

Thank you for your time

[bretrzaun]

This drops Symfony 4 compatibility :-(

Error: Call to undefined method Symfony\Component\HttpFoundation\RequestStack::getSession()

/var/www/vendor/gregwar/captcha-bundle/Type/CaptchaType.php:48

[Gregwar]

You are right, we should adjust the table here accordingly: https://github.com/Gregwar/CaptchaBundle#compatibility-with-symfony

Can you confirm it's ok if you use v2.1.5 ?

[bretrzaun]

v2.1.5 works fine.

Doing this in a bugfix release is probably not a good idea. This would prevent you from creating further fixes for Symfony-4- compatible versions.

[Gregwar]

Ok, here is what I suggest:

• Remove v2.1.6 and v2.1.7 tags
• Tag v2.2 with Sf updates, and update composer.json to drop Symfony 4
  • I guess changing "symfony/framework-bundle": "~4.0|~5.0" to "symfony/framework-bundle": "~5.0|~6.0"` is ok ?
• Update README table

Does it sounds good to you ?

[bretrzaun]

Yes - sounds good to me.

[Gregwar]

Ok it's done, now on v2.2.0

[Gregwar]

(Plus edited composer.json) If you can give it a try, tell me if it installs correctly on Sf4

[bretrzaun]

https://github.com/Gregwar/CaptchaBundle/blob/v2.2.0/composer.json still allows Symfony 4, so it still updates to that version.

[bretrzaun]

The 2.1.7 release is also still available from packagist: https://packagist.org/packages/gregwar/captcha-bundle#v2.1.7

[Gregwar]

You are right It should be fine now, I bumped v2.2.0 that is no longer compatible with Sf4 and removed irrelevant versions from packagist as well