Gregwar / FormBundle

Provides the "entity_id" type (read "entity identifier")
MIT License
64 stars 27 forks source link

3.0 compatibility #39

Open sblondeau opened 8 years ago

sblondeau commented 8 years ago

Hello Is it compatible with 3.0 version of symfony ? Thanks in advance.

dkorsak commented 8 years ago

Is not

dkorsak commented 8 years ago

Can you make this bundle to work with Symfony 3?

Koc commented 7 years ago

@Gregwar can you tag new version for current master?

DavidGarciaCat commented 6 years ago

Hey there,

No new updates on this matter? I can see here that we're still stuck on Symfony 2.x however versions 3.4 and 4.0 have been released already, so keep this bundle on 2.x is a blocker for those who want to update to a newer version of Symfony.

Also, any plans to make it compatible with Symfony v4.0?

Cheers,

DavidGarciaCat commented 6 years ago

Hey there,

I can't see any Travis / Scrutinizer or any other CI tool so it's impossible to know if there is an error running tests. When I do it locally then I get this output:

PHPUnit 6.5.7 by Sebastian Bergmann and contributors.

EEF                                                                 3 / 3 (100%)

Time: 982 ms, Memory: 20.00MB

There were 2 errors:

1) Gregwar\FormBundle\Tests\Functional\FormTest::testForm with data set #0 (true, 'hidden')
Symfony\Component\Form\Exception\InvalidArgumentException: Could not load type "form": class does not exist.

.../FormBundle/vendor/symfony/symfony/src/Symfony/Component/Form/FormRegistry.php:86
.../FormBundle/vendor/symfony/symfony/src/Symfony/Component/Form/FormFactory.php:58
.../FormBundle/Tests/Functional/FormTest.php:22

2) Gregwar\FormBundle\Tests\Functional\FormTest::testForm with data set #1 (false, 'text')
Symfony\Component\Form\Exception\InvalidArgumentException: Could not load type "form": class does not exist.

.../FormBundle/vendor/symfony/symfony/src/Symfony/Component/Form/FormRegistry.php:86
.../FormBundle/vendor/symfony/symfony/src/Symfony/Component/Form/FormFactory.php:58
.../FormBundle/Tests/Functional/FormTest.php:22

--

There was 1 failure:

1) Gregwar\FormBundle\Tests\Functional\FormTest::testFormWithNoClass
Failed asserting that exception of type "Symfony\Component\Form\Exception\InvalidArgumentException" matches expected exception "Symfony\Component\OptionsResolver\Exception\MissingOptionsException". Message was: "Could not load type "form": class does not exist." at
.../FormBundle/vendor/symfony/symfony/src/Symfony/Component/Form/FormRegistry.php:86
.../FormBundle/vendor/symfony/symfony/src/Symfony/Component/Form/FormFactory.php:58
.../FormBundle/Tests/Functional/FormTest.php:45
.

ERRORS!
Tests: 3, Assertions: 1, Errors: 2, Failures: 1.

I guess it should be reviewed before to tag it for Symfony 3.x

When I ran composer install I got these packages:

doctrine/annotations           v1.4.0  Docblock Annotations Parser
doctrine/cache                 v1.6.2  Caching library offering an object-oriented API for many cache backends
doctrine/collections           v1.4.0  Collections Abstraction library
doctrine/common                v2.7.3  Common Library for Doctrine projects
doctrine/dbal                  v2.5.13 Database Abstraction Layer
doctrine/doctrine-bundle       1.8.1   Symfony DoctrineBundle
doctrine/doctrine-cache-bundle 1.3.2   Symfony Bundle for Doctrine Cache
doctrine/inflector             v1.2.0  Common String Manipulations with regard to casing and singular/plural rules.
doctrine/instantiator          1.0.5   A small, lightweight utility to instantiate objects in PHP without invoking ...
doctrine/lexer                 v1.0.1  Base library for a lexer that can be used in Top-Down, Recursive Descent Par...
doctrine/orm                   v2.5.14 Object-Relational-Mapper for PHP
fig/link-util                  1.0.0   Common utility implementations for HTTP links
jdorn/sql-formatter            v1.2.17 a PHP SQL highlighting library
paragonie/random_compat        v2.0.11 PHP 5.x polyfill for random_bytes() and random_int() from PHP 7
psr/cache                      1.0.1   Common interface for caching libraries
psr/container                  1.0.0   Common Container Interface (PHP FIG PSR-11)
psr/link                       1.0.0   Common interfaces for HTTP links
psr/log                        1.0.2   Common interface for logging libraries
psr/simple-cache               1.0.0   Common interfaces for simple caching
symfony/polyfill-apcu          v1.7.0  Symfony polyfill backporting apcu_* functions to lower PHP versions
symfony/polyfill-intl-icu      v1.7.0  Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-mbstring      v1.7.0  Symfony polyfill for the Mbstring extension
symfony/polyfill-php56         v1.7.0  Symfony polyfill backporting some PHP 5.6+ features to lower PHP versions
symfony/polyfill-php70         v1.7.0  Symfony polyfill backporting some PHP 7.0+ features to lower PHP versions
symfony/polyfill-util          v1.7.0  Symfony utilities for portability of PHP codes
symfony/symfony                v3.4.4  The Symfony PHP framework
twig/twig                      v2.4.4  Twig, the flexible, fast, and secure template language for PHP

Cheers,