search

Gregwar / Image

A PHP library to handle images
MIT License
1k stars 190 forks source link

Add a gaussian blur feature #104

Closed yamilovs closed 7 years ago

yamilovs commented 8 years ago

Hello guys! Can u check this PR?

PS. I'm sorry about another one (5 mins later) im new to github =)

soullivaneuh commented 8 years ago
yamilovs commented 8 years ago

@Soullivaneuh hello! I fixed string for StyleCI. But i think i cant add a test for Gaussian Blur. Its like smooth() or sepia() methods, and i dont know how i can test it) Sry)

soullivaneuh commented 8 years ago

Should be here: https://github.com/Gregwar/Image/blob/master/tests/ImageTests.php

If you can't assert data, at least just run the method to see if it's running.

cc @Gregwar

yamilovs commented 8 years ago

@Soullivaneuh, ok i added a simple test for this filter;

yamilovs commented 8 years ago

and one more comment: i have tried to run phpinit for this repo, but it failed with this message:

Configuration read from /var/www/GregwarImage/phpunit.xml.dist PHP Fatal error: Class 'Gregwar\Cache\Cache' not found in /var/www/GregwarImage/Image.php on line 122

is that ok?

Gregwar commented 8 years ago

@yamilovs you need to run composer install first

yamilovs commented 8 years ago

@Gregwar oh thanks for this comment. Its also work for me now)

soullivaneuh commented 8 years ago

@Gregwar what do you think of https://github.com/Gregwar/Image/pull/104/files#r45178153?

yamilovs commented 8 years ago

Hello guys! any progress here?

yamilovs commented 8 years ago

ping @Gregwar I realy would like this feature in your library and in a symfony2 bundle =)

williamrijksen commented 8 years ago

+1 for this PR!

cord commented 7 years ago

+1 for this PR!

Gregwar commented 7 years ago

@Soullivaneuh is it ok for you?

Gregwar commented 7 years ago

Thanks for contributing