search

Gregwar / Image

A PHP library to handle images
MIT License
1k stars 190 forks source link

Fix creating new image if file is unchanged. #116

Open garygreen opened 8 years ago

garygreen commented 8 years ago

Fixes #115.

garygreen commented 8 years ago

@Gregwar any news on this?

hirbod commented 8 years ago

👍 really important fix

Gregwar commented 8 years ago

Why the quality have to be 100 for this?

garygreen commented 8 years ago

Because it essentially means your not changing the image. If you wanted 100% of the original quality image, that means you just want to copy it. If it's 99% that means you want to change the image to a 1% lower quality version. That's how I see it anyway...

garygreen commented 8 years ago

Any news @Gregwar ?

garygreen commented 8 years ago

@Gregwar @Soullivaneuh any news on this? At this rate I'll have to maintain a separate fork as this package seems quite slow on PRs at the moment.... :cry:

garygreen commented 8 years ago

@Gregwar Bump again, any news buddy? :smile:

Gregwar commented 8 years ago

Hello Sorry for the delay Shouldn't we test if the target type is also unchanged?