search

Gregwar / Image

A PHP library to handle images
MIT License
1k stars 191 forks source link

Add test by Github Actions #177

Closed Rotzbua closed 2 years ago

Rotzbua commented 2 years ago

Travis does not offer an easy free tier for open source, so I replaced it by the new Github Action service. I did not got the end of life php versions running properly, so dropped them. Before the usual complains: people with eol php can still use the older lib versions. Best wishes

Changes:

Chris53897 commented 2 years ago

Looks good at first sight. @Gregwar Is there any chance this is getting merged?

Gregwar commented 2 years ago

Looks good to me too.

Just one question, can you comment on the practice of using self::assertSame instead of $this->assertSame ? I understand that the method is indeed static and that it is just a question of practice, but, from the official phpunit latest documentation, $this-> is used: https://phpunit.readthedocs.io/fr/latest/assertions.html#assertsame

Chris53897 commented 2 years ago

This if often detected by the IDE, and an auto-suggestion. In my Case PhpStorm and i apply them very often. That is maybe the reason, too for @Rotzbua

Gregwar commented 2 years ago

Ok, actually PHPUnit says it's fine to use static version as well (https://phpunit.readthedocs.io/en/9.5/assertions.html) Thanks for contributing!

Chris53897 commented 2 years ago

Thanks. Now it is easier to send new PRs.