search

Gregwar / Image

A PHP library to handle images
MIT License
993 stars 190 forks source link

Sharp #58

Open iuli-dercaci opened 9 years ago

iuli-dercaci commented 9 years ago

sharp() method is barely useful - it adds too much of sharp, probably there is a possibility to add as a param amount of sharp wanted

Gregwar commented 9 years ago

Hello, It uses internally imagefilter() with MEAN_REMOVAL filter which has no argument And I guess implementing this in pure-PHP would be computationally terrible

hirbod commented 9 years ago

Hi @Gregwar , hi @site-me,

just saw this issue and as I also needed this functionality I've just implemented it.

63

I did not edit nor delete sharp(), I've just added a new filter which can be called trough ->sharpen() It's kinda hard stuff to meme photoshop functionality but it's not computationally terrible. Just keep in mind to call this filter on last position (before save() or get() / png()... of course)

More information in my PR #63

Hope you guys like it!

Crop without ->sharpen() 145f12f0a61dcd9f84ba09ac7a67877b766cbca3

Crop with ->sharpen() (default settings) 9a5eb7793597a0d0dd0f01463248bb77d8ece814

Btw, I'm that pretty guy on the left :smile:

iuli-dercaci commented 9 years ago

Good work. Very handsome guy :)

hirbod commented 9 years ago

Just a small correction: GIF is supported