Gregwar / ImageBundle

Image manipulation bundle for Symfony 2
MIT License
195 stars 50 forks source link

Fix deprecated `assets.packages` service call over Symfony 3.2 #111

Closed Sentence closed 6 years ago

Sentence commented 6 years ago

User Deprecated: The "assets.packages" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead.

Gregwar commented 6 years ago

Looks like your PR is changing the name of the package (composer.json), would you mind fixing it?

Gregwar commented 6 years ago

I eventually did the changes manually, thanks for contributing!

Sentence commented 6 years ago

Sorry for doing that, and many thanks for fixing it, cheer! :)

v03adk commented 6 years ago

phpdoc section of the __construct is wrong now