Symfony 5 support

[Zausenec]

Need Sf5 support please! I found only the issue with this line https://github.com/Gregwar/ImageBundle/blob/cc4bc913b7662d3532b99ce4617de6f13fe1ac7d/DependencyInjection/Configuration.php#L28 kernel.root_dir is no longer supported, and it breaks container build

[sergioplaza]

Change -> scalarNode ('web_dir') -> defaultValue ('% kernel.project_root% / .. / web') -> end ()

by -> scalarNode ('web_dir') -> defaultValue ('% kernel.project_dir% / .. / web') -> end ()

[Zausenec]

I now, but this is not generic and may cause BC break, so I can't contribute PR.

[lordjancso]

@Gregwar Are you planning to release an SF5 compatible version of this bundle?

[aykonsvk]

Can't you ask for SF version? then call method with corresponding data. It will be still generic

[aykonsvk]

I have fixed issues with SF 5 on my fork would you merge it? Probably not into the master because of BC

[Gregwar]

Hi, It should be OK now, I published a v3 that should be compliant to Sf5

BC is broken because we need Twig 2, but this is the work of composer, so I also bumped twig dependency to twig 2

Bundle worked for me on a simple test (image resize), ping me if any issue appear

[azhararmar]

It cannot be installed in Symfony 5 since it is asking Twig3 dependency.

[pwnyprod]

The only Problem is the dependency "twig/twig": "^2.0" which limit to twig2 but symfony requires twig3. We need just the twig3 dependency in composer

[Gregwar]

Ok, is it safe to bump

"twig/twig": "^1.12 || ^2.0"

To

"twig/twig": "^1.12 || ^2.0 || ^3.0"