search

Gregwar / ImageBundle

Image manipulation bundle for Symfony 2
MIT License
195 stars 50 forks source link

Update ImageHandling.php, add fallbackImage var. #127

Open asistent0 opened 1 year ago

asistent0 commented 1 year ago

Fix problem "Creation of dynamic property Gregwar\ImageBundle\Services\ImageHandling::$fallbackImage is deprecated"

alexbusu commented 10 months ago

@Gregwar let's have this one merged, please :)

joesenova commented 4 weeks ago

Can we change the constructor to following:

public function __construct(private string $cacheDirectory, private int $cacheDirMode, private string $handlerClass, private ContainerInterface $container, private Packages $assetsPackages, private KernelInterface|FileLocatorInterface $fileLocator, private bool $throwException, private string $fallbackImage)

Then also if you can add the return type of the ::load() method to void

That will solve the deprecation messages for Symfony 6.4.* and 7.0

@Gregwar Is there any chance we can get this merged is with the changes I am suggesting above.