search

Gregwar / ImageBundle

Image manipulation bundle for Symfony 2
MIT License
195 stars 50 forks source link

Fix deprecated Twig_Function_Method usage #82

Closed soullivaneuh closed 9 years ago

Gregwar commented 9 years ago

Does it breaks some BC?

soullivaneuh commented 9 years ago

@Gregwar Absolutly not. User just has to get twig >= 1.12 that still is a 1.x version.

Code runtime will still be the same. :+1:

Gregwar commented 9 years ago

Ok, thanks for contributing

soullivaneuh commented 9 years ago

Thanks. Could we have a new release tag for this?

Gregwar commented 9 years ago

Of course I am away right now, do not hesitate to ping me later if I forget

Gregwar commented 9 years ago

tagged v2.1.0

soullivaneuh commented 9 years ago

@Gregwar Ok!

BTW, if you need help to maintain Image and ImageBundle project, I would be glad to be part of contributors. ;-)

soullivaneuh commented 9 years ago

2.1.0? I would tag a new patch instead because it's not a new feature but a deprecated fix.

What do you think?

Gregwar commented 9 years ago

You're right, I tagged v2.0.21 instead

Gregwar commented 9 years ago

I can indeed consider including you as a contributor ;-)

soullivaneuh commented 9 years ago

I can indeed consider including you as a contributor ;-)

Thank you. I can help maintaining especially for Image and ImageBundle, but I can help for another if you want me for that. :+1:

Gregwar commented 9 years ago

Btw, je suis aussi français :-)

soullivaneuh commented 9 years ago

Ha ha bonjour !

Nice to know it, but I would still speak english on GitHub issues. ;-)

Gregwar commented 9 years ago

You are now collaborator of both repositories

soullivaneuh commented 9 years ago

Thanks! :+1: