Improve Twig extension - Githubissues

Gregwar / ImageBundle

Image manipulation bundle for Symfony 2

MIT License

195 stars 50 forks source link

Closed soullivaneuh closed 9 years ago

soullivaneuh commented 9 years ago

Passing the whole container is useless and will reduce performance. Only needed services and parameters are passed to the constructor.
Twig environment is not used. Removing.
Add PHPDoc blocks on methods

soullivaneuh commented 9 years ago

@Gregwar Don't know if it should be a patch or a major.

Could be BC break for class extends but I don't see why developer may extends this class...

I let you decide and merge.

soullivaneuh commented 9 years ago

ping @Gregwar

Gregwar commented 9 years ago

Sounds good to me

soullivaneuh commented 9 years ago

Thanks. Can I push a new patch version for that? :-)

Gregwar commented 9 years ago

No problem ;-)