search

Greifent / afc-gui

GUI for the asus-fan-control project
MIT License
38 stars 5 forks source link

Add image to README.md #3

Closed dominiksalvet closed 4 years ago

dominiksalvet commented 4 years ago

It would be great to add a demonstration image of this program running to the README.md so that people know what to expect. This image can also motivate others to download afc-gui. :tada:

Feel free to add the image once you do not expect changing the program's design for a while. It does not have to be done right now so that the image is not changed every other commit or so, which is not so good for Git repositories. :smile:

Greifent commented 4 years ago

I'm still adding thing on an almost daily base, as soon as I'm on a good point I'll add an image.

dominiksalvet commented 4 years ago

Glad to hear that! Feel free to close this issue now or once you will have added them.

Greifent commented 4 years ago

I'll leave it open, so I will remember to do that

Greifent commented 4 years ago

I added the photos, those shouldn't change for a wile; I'm closing the issue

dominiksalvet commented 4 years ago

Great! One little note - it would be great to have the selection window depicted while located in the ~/.local/share/afc-gui/temperaturesPreset directory where default presets are actually placed as it is not a standard place and it can help many people.

Greifent commented 4 years ago

Yes I was thinking about it, I need to figure out how to do it

dominiksalvet commented 4 years ago

Yes I was thinking about it, I need to figure out how to do it

Install afc-gui using GitPack? :smile: It will create the directory for you by your GitPack map. To show hidden files (file names beginning with a dot) use Ctrl+H or right click and Show Hidden Files.

BTW, good job with README.md! It is good to see it continuously improving! :+1:

Did you know that GitPack has its own GitHub topic, which you can use as well. You can also add other to make your repository more reachable. :rocket:

Greifent commented 4 years ago

If I understood, you are suggesting that the pick file dialog open directly in the ~/.local/share/afc-gui/temperaturesPreset directory, I need to figure out how to open that window in that directory, I have installed on my machine using gitpack to see if it work fine, and the dialog open in the ~ directory

Greifent commented 4 years ago

Thanks, it took me 30 minutes to load the images. I'm happy that you like it

dominiksalvet commented 4 years ago

If I understood, you are suggesting that the pick file dialog open directly in the ~/.local/share/afc-gui/temperaturesPreset directory, I need to figure out how to open that window in that directory, I have installed on my machine using gitpack to see if it work fine, and the dialog open in the ~ directory

Nope, you are talking about something else. But that would be a great idea as well to have it opened in that directory by default so that people do not have to find it themselves.

What I was talking about, however, is to take a new screenshot of the file selection window while being in that directory and replace the current README.md image with it. Only to show people where to look for these presets. But opening that file dialog directly in that directory by default would make things even easier! :rocket:

Greifent commented 4 years ago

Oh, yeah that make sense, I didn't thought about that

Greifent commented 4 years ago

Done that. For the other one I need to look how to do that

dominiksalvet commented 4 years ago

Good job! :+1: :clap: