It was suggested in the discord discussions that perhaps we should generate IDs using getClass().getSimpleName(). For example,
public static final String ID = DefaultMod.makeID("DefaultCommonAttack");
would become
public static final String ID = DefaultMod.makeID(getClass().getSimpleName());.
The benefits of doing this are:
It's less tempting for people to change a component and hardcode it if it looks like there's only one choice
Less typing if someone wants to rename both the class and the ID
One less area for people to mod developers to look for problems in
I can't think of much of a drawback, unless someone wants a card to not have its classname as its ID like Claw or wants to change how classes are alphabetically sorted. Or possibly, someone may jump off the rails and give up on using DefaultBaseMod altogether, but that sounds unlikely for newcomers already looking for a starting point.
This idea synergises with a later idea I plan to post here involving reading and setting the description only in the abstract superclasses.
It was suggested in the discord discussions that perhaps we should generate IDs using getClass().getSimpleName(). For example,
public static final String ID = DefaultMod.makeID("DefaultCommonAttack");would becomepublic static final String ID = DefaultMod.makeID(getClass().getSimpleName());.The benefits of doing this are:
I can't think of much of a drawback, unless someone wants a card to not have its classname as its ID like Claw or wants to change how classes are alphabetically sorted. Or possibly, someone may jump off the rails and give up on using DefaultBaseMod altogether, but that sounds unlikely for newcomers already looking for a starting point.
This idea synergises with a later idea I plan to post here involving reading and setting the description only in the abstract superclasses.