GrepoDataTools / grepodata-frontend

Angular 11 frontend for grepodata.com
https://grepodata.com
GNU General Public License v3.0
7 stars 0 forks source link

Customize generated BB code for ghost towns #39

Open PoLaKoSz opened 1 week ago

PoLaKoSz commented 1 week ago

Is your feature request related to a problem? Please describe. On long running worlds players can have a lot of (500+) towns on multiple seas. When somebody leaves ghost towns behined we post the town list to our forum. This BB code occasionally exceeds the maximum number of characters (as of today 30 000). Other than that we only interested in 2-3 seas but here (without checking one-by-one) there is probably towns on seas far from us that we don't care.

Describe the solution you'd like A dropdown with 3 values that would control how to list the ghost towns on GrepoData.com and for the genereted BB code:

This simple solution would make our lives much more easier because we would sort by sea number and we would delete rows where the town point is less then ideal (~5 000) or the sea is not close to us and we wouldn't conquer those towns anyway. Persist the selected dropdown value would be awesome too. :slightly_smiling_face:

I'm not really good at UIs, here is a preview (just edited on GrepoData): image

Describe alternatives you've considered Checkboxes for each sea (where at least 1 ghost town present) to add/remove to the displayed list/generated code and an input field to specify a minimum town point.

If this request gets a green light i would like to take a stab at it.

CamielK commented 1 week ago

Nice idea! You are very welcome to make a PR, but I warn you, my frontend code is not the cleanest 😅

To help you on your way, the code from your screenshot starts here: https://github.com/GrepoDataTools/grepodata-frontend/blob/30707ad36241948d262199347b7c637dcfa8a38a/src/app/player/player.component.html#L306

To run the frontend locally you can just run ng serve in the root, after installing Angular. You do not need any configs because by default it runs against the prod API

thanks for your contributions so far :D

P.S. Maybe we can also add pagination to the BB code such that each page does not exceed the max characters

PoLaKoSz commented 3 days ago

This is the current version (Should i open a PR maybe?):

https://github.com/user-attachments/assets/501862c6-b4b7-41bd-934f-b8c36a4006a2

BB code pagination Currently (Grepolis v2.325.0)

Can i refactor the Ghost towns tab (which contains the Ghost towns and BB code tabs into a separate component in this PR to keep the PlayerComponent manageable?

Current state: work-in-progress

Any feedback would be greatly appreciated.