Closed killme2008 closed 1 week ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Latest commit: |
826a67f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ad4a0c60.greptime-docs.pages.dev |
Branch Preview URL: | https://feature-admin-statements.greptime-docs.pages.dev |
I feel we need to use a verb for an action in SQL, like select/delete/update are all verbs that followed. admin
are mostly used as a noun in computer. Although it has a verb form "administer", it means someone is in charge of something.
My suggestion is to use another keyword for this type of function execution, like
It's the statement of clickhouse. I think it's good. We already discussed it.
https://clickhouse.com/docs/en/sql-reference/statements
I didn't see similar statement from clickhouse's docs.
https://clickhouse.com/docs/en/sql-reference/statements
I didn't see similar statement from clickhouse's docs.
I think the choice of keywords doesn't really matter. We only use this keyword for administration functions or commands.
It's proposed by @evenyag at https://github.com/GreptimeTeam/greptimedb/issues/4462
https://clickhouse.com/docs/en/sql-reference/statements
I didn't see similar statement from clickhouse's docs.
My mistake, just like the system
statement:
https://clickhouse.com/docs/en/sql-reference/statements/system
What's Changed in this PR
Describe the change in this PR
admin
instead ofselect
.ADMIN
statement reference.Checklist
sidebars.ts
matches the current document structure when you changed the document structure.