search

GreptimeTeam / greptimedb-ingester-go

A Go ingester for GreptimeDB, which is compatible with GreptimeDB protocol and lightweight.
Apache License 2.0
15 stars 5 forks source link

feat: support delete record #29

Closed JetSquirrel closed 8 months ago

JetSquirrel commented 8 months ago

What's changed and what's your intention?

support delete specified row(s) from GreptimeDB

Checklist

Refer to a related PR or issue link

This closes #20

yuanbohan commented 8 months ago

Thanks for your contribution, and good documentation, and unit test. Excellent job :smile:

close #20

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 62.50000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 76.53%. Comparing base (08930f5) to head (9affbb2).

Files Patch % Lines
client.go 62.50% 10 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## ========================================== - Coverage 76.84% 76.53% -0.32% ========================================== Files 7 7 Lines 419 439 +20 ========================================== + Hits 322 336 +14 - Misses 76 80 +4 - Partials 21 23 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JetSquirrel commented 8 months ago

Thank you @yuanbohan point out the mistack, I forgate change the code comments, my bad. I already fix the mistacks.