search

GreptimeTeam / greptimedb-ingester-go

A Go ingester for GreptimeDB, which is compatible with GreptimeDB protocol and lightweight.
Apache License 2.0
15 stars 5 forks source link

Panic in CloseStream #36

Closed cedws closed 5 months ago

cedws commented 5 months ago

https://github.com/GreptimeTeam/greptimedb-ingester-go/blob/11097663940c13f4ab69148e145cfb0be6caeb13/client.go#L271-L282

CloseStream may attempt to use c.stream when it is nil, which happens if a stream has not previously been written to.

evenyag commented 5 months ago

Thanks for your report, this should be a bug. Would you be interested in submitting a PR to fix it? @cedws

cedws commented 5 months ago

Sorry, I just wanted to try out Greptime. I probably won't spend time on this.

evenyag commented 5 months ago

https://github.com/GreptimeTeam/greptimedb-ingester-go/pull/37 should fix this.